[WINDUPRULE-1019] adds eap 8 ruleset deprecated-initialcontextfactory… #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not ready to merge |
|
Hi @emmartins - I think you just need to change the iterable-filter size="3" to size="2" for the first rule test, and remove the second rule test and it should work. |
|
@PhilipCattanach yes but it should be 3, 2 in the class and 1 in the wsdl, so need something more in the rule, to catch the string value reference to the class name. I will investigate later today, just had to switch to something else yesterday. |
emmartins
force-pushed
the
WINDUPRULE-1019
branch
from
4e1c8f2
to
f5d37f0
Compare
emmartins
force-pushed
the
WINDUPRULE-1019
branch
from
f5d37f0
to
1b71a9b
Compare
|
ready to merge review |
|
@emmartins - Thank you. The rules look fine and my tests were successful. I'll merger to master. |
PhilipCattanach
added
auto-backport
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
PhilipCattanach
pushed a commit
that referenced
this pull request
Dec 13, 2023
…-is-removed (#1044) (#1045) (cherry picked from commit 3898ec3) Co-authored-by: Eduardo Martins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…-is-removed
Issue: https://issues.redhat.com/browse/WINDUPRULE-1019